migration - #689
Conversation
…not in a ready state to allow force removing of wallets (0xsequence#906)
* Pass request to PromptCodeHandler in guard registerUI * Fixing guard registerUI test
* guard: allow using recovery code as 2FA token * Cleanup types of ResponseFn --------- Co-authored-by: Corban Riley <corbanbrook@gmail.com>
* Add a way to reset 2fa when using a backup code * use the GuardToken type instead of breaking out the props
Sequence v3 rc4
* Use proper guard topology * Test and fixes * login and setup tests
* Add prod guard and identity instrument info * Remove completed TODOs
* Fix type exports to built declarations * Update repository links to current package paths * Improve Next app tooling and React typings * Expose primitives CLI bin and use base lint config
Bumps [turbo](https://github.com/vercel/turborepo) from 2.9.8 to 2.9.14. - [Release notes](https://github.com/vercel/turborepo/releases) - [Changelog](https://github.com/vercel/turborepo/blob/main/RELEASE.md) - [Commits](vercel/turborepo@v2.9.8...v2.9.14) --- updated-dependencies: - dependency-name: turbo dependency-version: 2.9.14 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Expose add login signer redirect metadata * Re-export CompleteRedirectWithMetadataArgs and CompleteRedirectMetadataResult from public index
| protected path = '/rpc/UserData/' | ||
|
|
||
| constructor(hostname: string, fetch: Fetch) { | ||
| this.hostname = hostname.replace(/\/*$/, '') |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Code Review
This pull request introduces extensive updates across the monorepo, including dependency upgrades (such as TypeScript 6, vitest 4, and ox 0.9.17), the addition of the @0xsequence/userdata package, and refactoring of the precondition and session management systems. Key improvements include lazy instantiation of DappTransport and ETHAuth proof persistence in @0xsequence/dapp-client, alongside the introduction of resolveCoreEnv in @0xsequence/wallet-core. However, several critical issues must be addressed: constructor parameters sequenceSessionStorage and redirectActionHandler in DappClient are not saved to the instance, which will cause runtime errors; the Arweave state reader contains while (true) loops that risk hanging on persistent rate limits; using Date.now() as a nonce in identity-instrument introduces security risks; DappTransport's base64 encoding fails on non-ASCII characters; redundant environment resolution exists in encrypted.ts; and a test assertion in guard remains hardcoded to 1 despite using a custom chain ID.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
No description provided.