Skip to content

migration - #689

Merged
Dargon789 merged 151 commits into
migrationfrom
Dargon789-patch-2
Jun 28, 2026
Merged

migration#689
Dargon789 merged 151 commits into
migrationfrom
Dargon789-patch-2

Conversation

@Dargon789

Copy link
Copy Markdown
Owner

No description provided.

tolgahan-arikan and others added 30 commits October 24, 2025 17:07
…not in a ready state to allow force removing of wallets (0xsequence#906)
* Pass request to PromptCodeHandler in guard registerUI

* Fixing guard registerUI test
* guard: allow using recovery code as 2FA token

* Cleanup types of ResponseFn

---------

Co-authored-by: Corban Riley <corbanbrook@gmail.com>
* Add a way to reset 2fa when using a backup code

* use the GuardToken type instead of breaking out the props
* Use proper guard topology

* Test and fixes

* login and setup tests
* Add prod guard and identity instrument info

* Remove completed TODOs
* Fix type exports to built declarations

* Update repository links to current package paths

* Improve Next app tooling and React typings

* Expose primitives CLI bin and use base lint config
taylanpince and others added 5 commits May 29, 2026 12:48
Bumps [turbo](https://github.com/vercel/turborepo) from 2.9.8 to 2.9.14.
- [Release notes](https://github.com/vercel/turborepo/releases)
- [Changelog](https://github.com/vercel/turborepo/blob/main/RELEASE.md)
- [Commits](vercel/turborepo@v2.9.8...v2.9.14)

---
updated-dependencies:
- dependency-name: turbo
  dependency-version: 2.9.14
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Expose add login signer redirect metadata

* Re-export CompleteRedirectWithMetadataArgs and CompleteRedirectMetadataResult from public index
protected path = '/rpc/UserData/'

constructor(hostname: string, fetch: Fetch) {
this.hostname = hostname.replace(/\/*$/, '')
@codesandbox

codesandbox Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we are unable to review this pull request

The GitHub API does not allow us to fetch diffs exceeding 20000 lines

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sequence-js-docs Canceled Canceled Jun 28, 2026 6:09pm
sequence-js-web Canceled Canceled Jun 28, 2026 6:09pm
sequence.js Ready Ready Preview, Comment Jun 28, 2026 6:09pm
wagmi-project Canceled Canceled Jun 28, 2026 6:09pm

@snyk-io

snyk-io Bot commented Jun 28, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces extensive updates across the monorepo, including dependency upgrades (such as TypeScript 6, vitest 4, and ox 0.9.17), the addition of the @0xsequence/userdata package, and refactoring of the precondition and session management systems. Key improvements include lazy instantiation of DappTransport and ETHAuth proof persistence in @0xsequence/dapp-client, alongside the introduction of resolveCoreEnv in @0xsequence/wallet-core. However, several critical issues must be addressed: constructor parameters sequenceSessionStorage and redirectActionHandler in DappClient are not saved to the instance, which will cause runtime errors; the Arweave state reader contains while (true) loops that risk hanging on persistent rate limits; using Date.now() as a nonce in identity-instrument introduces security risks; DappTransport's base64 encoding fails on non-ASCII characters; redundant environment resolution exists in encrypted.ts; and a test assertion in guard remains hardcoded to 1 despite using a custom chain ID.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/wallet/dapp-client/src/DappClient.ts
Comment thread packages/wallet/core/src/state/arweave/arweave.ts
Comment thread packages/wallet/core/src/state/arweave/arweave.ts
Comment thread packages/services/identity-instrument/src/index.ts Outdated
Comment thread packages/wallet/dapp-client/src/DappTransport.ts
Comment thread packages/wallet/core/src/signers/pk/encrypted.ts
Comment thread packages/services/guard/test/sequence.test.ts
@Dargon789 Dargon789 changed the title Dargon789 patch 2 migration Jun 28, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@vercel
vercel Bot temporarily deployed to Preview – sequence-js-docs June 28, 2026 18:00 Inactive
@vercel
vercel Bot temporarily deployed to Preview – sequence-js-web June 28, 2026 18:00 Inactive
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@vercel
vercel Bot temporarily deployed to Preview – sequence-js-docs June 28, 2026 18:01 Inactive
@vercel
vercel Bot temporarily deployed to Preview – sequence-js-web June 28, 2026 18:01 Inactive
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@vercel
vercel Bot temporarily deployed to Preview – sequence-js-docs June 28, 2026 18:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – sequence-js-web June 28, 2026 18:03 Inactive
@vercel
vercel Bot temporarily deployed to Preview – sequence-js-web June 28, 2026 18:09 Inactive
@vercel
vercel Bot temporarily deployed to Preview – sequence-js-docs June 28, 2026 18:09 Inactive
@vercel
vercel Bot temporarily deployed to Preview – wagmi-project June 28, 2026 18:09 Inactive
Repository owner deleted a comment from vercel Bot Jun 28, 2026
@Dargon789
Dargon789 merged commit c7c1093 into migration Jun 28, 2026
11 of 18 checks passed
@Dargon789
Dargon789 deleted the Dargon789-patch-2 branch June 28, 2026 18:22
@Dargon789 Dargon789 linked an issue Jun 30, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sequence diagram for Wallets.completeRedirect with metadata